From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LN2cG-0007r9-AD
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 05:04:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LN2cE-0007pH-JY
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 05:04:50 -0500
Received: from [199.232.76.173] (port=57179 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LN2cE-0007os-3B
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 05:04:50 -0500
Received: from mx2.redhat.com ([66.187.237.31]:38989)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dlaor@redhat.com>) id 1LN2cD-0005cl-F6
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 05:04:49 -0500
Message-ID: <496DB8D1.2070101@redhat.com>
Date: Wed, 14 Jan 2009 12:05:05 +0200
From: Dor Laor <dlaor@redhat.com>
MIME-Version: 1.0
References: <1231881829.9095.191.camel@bling>
In-Reply-To: <1231881829.9095.191.camel@bling>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/5] virtio-net: Allow setting the MAC
	address via set_config
Reply-To: dlaor@redhat.com, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@hp.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>

Alex Williamson wrote:
> Rename get_config for simplicity
>
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> ---
>
>  qemu/hw/virtio-net.c |   18 ++++++++++++++++--
>  1 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c
> index 1f9dc16..e9b3d46 100644
> --- a/qemu/hw/virtio-net.c
> +++ b/qemu/hw/virtio-net.c
> @@ -42,7 +42,7 @@ static VirtIONet *to_virtio_net(VirtIODevice *vdev)
>      return (VirtIONet *)vdev;
>  }
>  
> -static void virtio_net_update_config(VirtIODevice *vdev, uint8_t *config)
> +static void virtio_net_get_config(VirtIODevice *vdev, uint8_t *config)
>  {
>      VirtIONet *n = to_virtio_net(vdev);
>      struct virtio_net_config netcfg;
> @@ -51,6 +51,19 @@ static void virtio_net_update_config(VirtIODevice *vdev, uint8_t *config)
>      memcpy(config, &netcfg, sizeof(netcfg));
>  }
>  
> +static void virtio_net_set_config(VirtIODevice *vdev, const uint8_t *config)
> +{
> +    VirtIONet *n = to_virtio_net(vdev);
> +    struct virtio_net_config netcfg;
> +
> +    memcpy(&netcfg, config, sizeof(netcfg));
> +
> +    if (memcmp(netcfg.mac, n->mac, 6)) {
> +        memcpy(n->mac, netcfg.mac, 6);
> +        qemu_format_nic_info_str(n->vc, n->mac);
> +    }
> +}
> +
>   

What if the guest will chose the host's mac?
Thinking about it, I don't think we should test that.
A concerned host mgmt app can add ebtables roles for such a case.

Maybe we can optionally allow/deny it?