* [Qemu-devel] [PATCH] Fix Windows build
@ 2009-01-15 19:12 Hervé Poussineau
2009-01-15 21:39 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Hervé Poussineau @ 2009-01-15 19:12 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
Hi,
r6303 broke Windows build, where "noreturn" is a keyword used with
__declspec.
Attached patch fixes Windows build, by moving windows.h header inclusion
before Qemu noreturn define.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Hervé
[-- Attachment #2: fix_windows_build.diff --]
[-- Type: plain/text, Size: 698 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix Windows build
2009-01-15 19:12 [Qemu-devel] [PATCH] Fix Windows build Hervé Poussineau
@ 2009-01-15 21:39 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-01-15 21:39 UTC (permalink / raw)
To: qemu-devel
Hervé Poussineau wrote:
> Hi,
>
> r6303 broke Windows build, where "noreturn" is a keyword used with
> __declspec.
> Attached patch fixes Windows build, by moving windows.h header
> inclusion before Qemu noreturn define.
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Applied. Thanks.
There are CRs in the patch. Please watch out for that in the future.
Regards,
Anthony Liguori
> Hervé
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-15 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-15 19:12 [Qemu-devel] [PATCH] Fix Windows build Hervé Poussineau
2009-01-15 21:39 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).