From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNYhG-0001fY-5C
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 15:20:10 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNYhC-0001a6-Rx
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 15:20:06 -0500
Received: from [199.232.76.173] (port=46225 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNYh9-0001ZV-6W
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 15:20:03 -0500
Received: from mail-qy0-f20.google.com ([209.85.221.20]:56976)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LNYh2-0004QW-Kq
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 15:19:57 -0500
Received: by qyk13 with SMTP id 13so1478794qyk.8
	for <qemu-devel@nongnu.org>; Thu, 15 Jan 2009 12:19:49 -0800 (PST)
Message-ID: <496F9A59.4040503@codemonkey.ws>
Date: Thu, 15 Jan 2009 14:19:37 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Guest debugging support for KVM
References: <496DF9F5.1040404@siemens.com>
In-Reply-To: <496DF9F5.1040404@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> [ Also available via git://git.kiszka.org/qemu.git queue/gdb ]
>
> This is a backport of the guest debugging support for the KVM
> accelerator that is now part of the KVM tree. It implements the reworked
> KVM kernel API for guest debugging (KVM_CAP_SET_GUEST_DEBUG) which is
> not yet part of any mainline kernel but will probably be 2.6.30 stuff.
> So far supported is x86, but PPC is expected to catch up soon.
>
> Core features are:
>  - unlimited soft-breakpoints via code patching
>  - hardware-assisted x86 breakpoints and watchpoints
>
> Open issues: Writing soft breakpoints to BIOS code. cpu_memory_rw_debug
> does not work here. Suggestion to fix this cleanly are welcome.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
>  configure         |    4 +
>  exec.c            |   10 ++-
>  gdbstub.c         |   29 +++++++--
>  gdbstub.h         |    7 ++
>  kvm-all.c         |  172 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  kvm.h             |   41 +++++++++++++
>  target-i386/kvm.c |  172 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 423 insertions(+), 12 deletions(-)
>
> diff --git a/configure b/configure
> index a8ea55a..afbe1e0 100755
> --- a/configure
> +++ b/configure
> @@ -479,11 +479,11 @@ case "$cpu" in
>             ARCH_CFLAGS="-march=z900"
>             ;;
>      i386)
> -           ARCH_CFLAGS="-m32"
> +           ARCH_CFLAGS="-m32 -DCONFIG_X86"
>             ARCH_LDFLAGS="-m32"
>             ;;
>      x86_64)
> -           ARCH_CFLAGS="-m64"
> +           ARCH_CFLAGS="-m64 -DCONFIG_X86"
>             ARCH_LDFLAGS="-m64"
>             ;;
>  esac
>   

This seems unnecessary, no?

The rest looks good.

Regards,

Anthony Liguori