From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNZju-0006BV-3J for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:26:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNZjr-00069w-Hw for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:26:56 -0500 Received: from [199.232.76.173] (port=49370 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNZjr-00069r-Bf for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:26:55 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:51570) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNZjq-00075w-Nm for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:26:55 -0500 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate02.web.de (Postfix) with ESMTP id E1DEFF8E2BB9 for ; Thu, 15 Jan 2009 22:26:50 +0100 (CET) Received: from [88.65.46.76] (helo=[192.168.1.198]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #277) id 1LNZjm-0007Sb-00 for qemu-devel@nongnu.org; Thu, 15 Jan 2009 22:26:50 +0100 Message-ID: <496FAA15.806@web.de> Date: Thu, 15 Jan 2009 22:26:45 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <496DF9F5.1040404@siemens.com> <496F9A59.4040503@codemonkey.ws> In-Reply-To: <496F9A59.4040503@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig6C4914AEC1E43CAAF2775196" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] Guest debugging support for KVM Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6C4914AEC1E43CAAF2775196 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Jan Kiszka wrote: >> [ Also available via git://git.kiszka.org/qemu.git queue/gdb ] >> >> This is a backport of the guest debugging support for the KVM >> accelerator that is now part of the KVM tree. It implements the rework= ed >> KVM kernel API for guest debugging (KVM_CAP_SET_GUEST_DEBUG) which is >> not yet part of any mainline kernel but will probably be 2.6.30 stuff.= >> So far supported is x86, but PPC is expected to catch up soon. >> >> Core features are: >> - unlimited soft-breakpoints via code patching >> - hardware-assisted x86 breakpoints and watchpoints >> >> Open issues: Writing soft breakpoints to BIOS code. cpu_memory_rw_debu= g >> does not work here. Suggestion to fix this cleanly are welcome. >> >> Signed-off-by: Jan Kiszka >> --- >> >> configure | 4 + >> exec.c | 10 ++- >> gdbstub.c | 29 +++++++-- >> gdbstub.h | 7 ++ >> kvm-all.c | 172 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> kvm.h | 41 +++++++++++++ >> target-i386/kvm.c | 172 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 7 files changed, 423 insertions(+), 12 deletions(-) >> >> diff --git a/configure b/configure >> index a8ea55a..afbe1e0 100755 >> --- a/configure >> +++ b/configure >> @@ -479,11 +479,11 @@ case "$cpu" in >> ARCH_CFLAGS=3D"-march=3Dz900" >> ;; >> i386) >> - ARCH_CFLAGS=3D"-m32" >> + ARCH_CFLAGS=3D"-m32 -DCONFIG_X86" >> ARCH_LDFLAGS=3D"-m32" >> ;; >> x86_64) >> - ARCH_CFLAGS=3D"-m64" >> + ARCH_CFLAGS=3D"-m64 -DCONFIG_X86" >> ARCH_LDFLAGS=3D"-m64" >> ;; >> esac >> =20 >=20 > This seems unnecessary, no? Nope. I suggested and Avi merged a patch to define KVM_CAP_SET_GUEST_DEBUG only for those archs (ie. currently x86) that really support it. That avoids having to define empty stubs on the other KVM archs. So we need to define the proper arch switch to make the CAP appear in the kernel header. Also note that there are much more conditional CAP defines queued up or already merged into mainline. >=20 > The rest looks good. >=20 > Regards, >=20 > Anthony Liguori >=20 >=20 >=20 Jan --------------enig6C4914AEC1E43CAAF2775196 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAklvqhsACgkQniDOoMHTA+l1GwCfWpT5bN9FmRdCeffpOiOergw7 Z6QAniiCl86+IjHTKFaLMyClVY0orj+M =y74m -----END PGP SIGNATURE----- --------------enig6C4914AEC1E43CAAF2775196--