From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNZwq-0005Za-OQ for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:40:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNZwg-0005VW-Dq for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:40:18 -0500 Received: from [199.232.76.173] (port=37458 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNZwf-0005UM-1k for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:40:09 -0500 Received: from mail-qy0-f20.google.com ([209.85.221.20]:42377) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNZwd-0000P2-Tv for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:40:08 -0500 Received: by qyk13 with SMTP id 13so1959674qyk.10 for ; Thu, 15 Jan 2009 13:40:06 -0800 (PST) Message-ID: <496FAD2B.5080005@codemonkey.ws> Date: Thu, 15 Jan 2009 15:39:55 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix Windows build References: <496F8AB4.4050908@reactos.org> In-Reply-To: <496F8AB4.4050908@reactos.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hervé Poussineau wrote: > Hi, > > r6303 broke Windows build, where "noreturn" is a keyword used with > __declspec. > Attached patch fixes Windows build, by moving windows.h header > inclusion before Qemu noreturn define. > > Signed-off-by: Hervé Poussineau Applied. Thanks. There are CRs in the patch. Please watch out for that in the future. Regards, Anthony Liguori > Hervé