From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNa4A-0005jz-Bz for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:47:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNa49-0005iZ-3Y for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:47:53 -0500 Received: from [199.232.76.173] (port=38272 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNa48-0005iF-Ob for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:47:52 -0500 Received: from mx2.redhat.com ([66.187.237.31]:36322) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNa48-00017c-40 for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:47:52 -0500 Message-ID: <496FAF16.6040205@redhat.com> Date: Thu, 15 Jan 2009 23:48:06 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: Machine-readable or parseable qemu output References: <20090114111005.GB31839@amit-x200.pnq.redhat.com> <20090114112317.GD24995@redhat.com> <496F9C19.8020502@codemonkey.ws> <20090115205842.GJ23380@redhat.com> In-Reply-To: <20090115205842.GJ23380@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: chrisw@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, Amit Shah Daniel P. Berrange wrote: >> But you can conditionally use the new library instead of your custom >> parsing code for newer QEMU versions. >> > > That is true, but if there are a number of apps around which want to > support multiple versions of QEMU, it is beneficial to centralize > this conditional logic in libqemumonitor.so instead, of making each > app implement the compat logic for the existing monitor format. I'm > not against adding a new machine friendly monitor format, I'd just > prefer it if one library API could provide impl for both old and new > format, obviously preferring to use the new format where available. > Perhaps libvirt can donate its parsing code for use as a fallback in libqemumonitor.so. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.