From: Anthony Liguori <aliguori@us.ibm.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] Always return latest pmsts instead of the old one.
Date: Thu, 15 Jan 2009 15:55:45 -0600 [thread overview]
Message-ID: <496FB0E1.3050306@us.ibm.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21C9A0745@pdsmsx503.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> For get_pmsts of acpi, it should always return latest value instead of the old one.
> Xiantao
>
>
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Tue, 13 Jan 2009 17:42:16 +0800
> Subject: [PATCH] Always return latest pmsts instead of the old one.
>
> It may lead to the issue when booting windows guests with acpi=1
> if return the old pmsts.
>
> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
> qemu/hw/acpi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c
>
Please resubmit against QEMU, not kvm-userspace.
Regards,
Anthony Liguori
> index 0ff8851..8bde989 100644
> --- a/qemu/hw/acpi.c
> +++ b/qemu/hw/acpi.c
> @@ -94,7 +94,7 @@ static int get_pmsts(PIIX4PMState *s)
> d = muldiv64(qemu_get_clock(vm_clock), PM_FREQ, ticks_per_sec);
> if (d >= s->tmr_overflow_time)
> s->pmsts |= TMROF_EN;
> - return pmsts;
> + return s->pmsts;
> }
>
> static void pm_update_sci(PIIX4PMState *s)
>
next prev parent reply other threads:[~2009-01-15 21:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 7:09 [Qemu-devel] v2: KVM: support for 'count' in CPUID functions 4, 0xb and 0xd Amit Shah
2009-01-13 7:09 ` [Qemu-devel] [PATCH] KVM: CPUID takes ecx as input value for some functions Amit Shah
2009-01-13 7:09 ` [Qemu-devel] [PATCH] KVM: Fetch sub-leaf cpuid values for functions 4, 0xb, 0xd Amit Shah
2009-01-13 8:25 ` [Qemu-devel] v2: KVM: support for 'count' in CPUID functions 4, 0xb and 0xd Alexander Graf
2009-01-13 9:10 ` Amit Shah
2009-01-13 11:06 ` Amit Shah
2009-01-13 9:56 ` [Qemu-devel] [PATCH] Always return latest pmsts instead of the old one Zhang, Xiantao
2009-01-15 6:27 ` [Qemu-devel] " Zhang, Xiantao
2009-01-15 21:55 ` Anthony Liguori [this message]
2009-01-19 14:12 ` Zhang, Xiantao
2009-01-21 3:51 ` Zhang, Xiantao
2009-01-21 16:35 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496FB0E1.3050306@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).