From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNaBx-00076O-01
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:55:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNaBv-00074V-Ag
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:55:56 -0500
Received: from [199.232.76.173] (port=39104 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNaBv-00074I-31
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:55:55 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:35430)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LNaBu-00023I-MZ
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 16:55:54 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0FLsR9F023400
	for <qemu-devel@nongnu.org>; Thu, 15 Jan 2009 16:54:27 -0500
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n0FLtrGU184268
	for <qemu-devel@nongnu.org>; Thu, 15 Jan 2009 16:55:53 -0500
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n0FLt3oU016294
	for <qemu-devel@nongnu.org>; Thu, 15 Jan 2009 16:55:03 -0500
Message-ID: <496FB0E1.3050306@us.ibm.com>
Date: Thu, 15 Jan 2009 15:55:45 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1231830545-1788-1-git-send-email-amit.shah@redhat.com>
	<706158FABBBA044BAD4FE898A02E4BC21C9A0745@pdsmsx503.ccr.corp.intel.com>
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21C9A0745@pdsmsx503.ccr.corp.intel.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Always return latest pmsts instead of the
	old one.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

Zhang, Xiantao wrote:
> For get_pmsts of acpi, it should always return latest value instead of the old one. 
> Xiantao
>
>
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Tue, 13 Jan 2009 17:42:16 +0800
> Subject: [PATCH] Always return latest pmsts instead of the old one.
>
> It may lead to the issue when booting windows guests with acpi=1
> if return the old pmsts.
>
> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>
> ---
>  qemu/hw/acpi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c
>   

Please resubmit against QEMU, not kvm-userspace.

Regards,

Anthony Liguori

> index 0ff8851..8bde989 100644
> --- a/qemu/hw/acpi.c
> +++ b/qemu/hw/acpi.c
> @@ -94,7 +94,7 @@ static int get_pmsts(PIIX4PMState *s)
>      d = muldiv64(qemu_get_clock(vm_clock), PM_FREQ, ticks_per_sec);
>      if (d >= s->tmr_overflow_time)
>          s->pmsts |= TMROF_EN;
> -    return pmsts;
> +    return s->pmsts;
>  }
>  
>  static void pm_update_sci(PIIX4PMState *s)
>