From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH 5 of 7] graphical_console_init change
Date: Thu, 15 Jan 2009 16:19:14 -0600 [thread overview]
Message-ID: <496FB662.6080806@codemonkey.ws> (raw)
In-Reply-To: <494AA0E0.5090700@eu.citrix.com>
Stefano Stabellini wrote:
> This patch changes the graphical_console_init function to return an
> allocated DisplayState instead of a QEMUConsole.
>
> This patch contains just the graphical_console_init change and few other
> modifications mainly in console.c and vl.c.
> It was necessary to move the display frontends (e.g. sdl and vnc)
> initialization after machine->init in vl.c.
>
> This patch does *not* include any required changes to any device, these
> changes come with the following patches.
>
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
This breaks the build.
/home/anthony/svn/qemu/hw/ssd0303.c: In function ‘ssd0303_init’:
/home/anthony/svn/qemu/hw/ssd0303.c:320: warning: passing argument 1 of
‘graphic_console_init’ from incompatible pointer type
/home/anthony/svn/qemu/hw/ssd0303.c:320: warning: passing argument 3 of
‘graphic_console_init’ from incompatible pointer type
/home/anthony/svn/qemu/hw/ssd0303.c:320: error: too many arguments to
function ‘graphic_console_init’
/home/anthony/svn/qemu/hw/ssd0303.c:320: warning: assignment from
incompatible pointer type
/home/anthony/svn/qemu/hw/ssd0303.c:321: warning: passing argument 1 of
‘qemu_console_resize’ from incompatible pointer type
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-01-15 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 19:13 [Qemu-devel] [PATCH 5 of 7] graphical_console_init change Stefano Stabellini
2009-01-15 22:19 ` Anthony Liguori [this message]
2009-01-16 11:15 ` Stefano Stabellini
2009-01-16 11:30 ` Stefano Stabellini
-- strict thread matches above, loose matches on Subject: below --
2008-11-26 17:47 Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496FB662.6080806@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).