From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNaYn-0007o7-4t
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 17:19:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNaYl-0007nK-D5
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 17:19:32 -0500
Received: from [199.232.76.173] (port=53374 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNaYl-0007nB-1M
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 17:19:31 -0500
Received: from mail-qy0-f20.google.com ([209.85.221.20]:48075)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LNaYk-0004Q1-EH
	for qemu-devel@nongnu.org; Thu, 15 Jan 2009 17:19:30 -0500
Received: by qyk13 with SMTP id 13so1986032qyk.10
	for <qemu-devel@nongnu.org>; Thu, 15 Jan 2009 14:19:25 -0800 (PST)
Message-ID: <496FB662.6080806@codemonkey.ws>
Date: Thu, 15 Jan 2009 16:19:14 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 5 of 7] graphical_console_init change
References: <494AA0E0.5090700@eu.citrix.com>
In-Reply-To: <494AA0E0.5090700@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Stefano Stabellini wrote:
> This patch changes the graphical_console_init function to return an
> allocated DisplayState instead of a QEMUConsole.
>
> This patch contains just the graphical_console_init change and few other
> modifications mainly in console.c and vl.c.
> It was necessary to move the display frontends (e.g. sdl and vnc)
> initialization after machine->init in vl.c.
>
> This patch does *not* include any required changes to any device, these
> changes come with the following patches.
>
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>   

This breaks the build.

/home/anthony/svn/qemu/hw/ssd0303.c: In function ‘ssd0303_init’:
/home/anthony/svn/qemu/hw/ssd0303.c:320: warning: passing argument 1 of 
‘graphic_console_init’ from incompatible pointer type
/home/anthony/svn/qemu/hw/ssd0303.c:320: warning: passing argument 3 of 
‘graphic_console_init’ from incompatible pointer type
/home/anthony/svn/qemu/hw/ssd0303.c:320: error: too many arguments to 
function ‘graphic_console_init’
/home/anthony/svn/qemu/hw/ssd0303.c:320: warning: assignment from 
incompatible pointer type
/home/anthony/svn/qemu/hw/ssd0303.c:321: warning: passing argument 1 of 
‘qemu_console_resize’ from incompatible pointer type


Regards,

Anthony Liguori