From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNmhO-0005ip-OY
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 06:17:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNmhN-0005hl-0r
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 06:17:14 -0500
Received: from [199.232.76.173] (port=35990 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNmhM-0005hU-Nw
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 06:17:12 -0500
Received: from smtp.eu.citrix.com ([62.200.22.115]:50854)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LNmhM-0008Vf-F3
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 06:17:12 -0500
Message-ID: <49706C67.8050904@eu.citrix.com>
Date: Fri, 16 Jan 2009 11:15:51 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 5 of 7] graphical_console_init change
References: <494AA0E0.5090700@eu.citrix.com> <496FB662.6080806@codemonkey.ws>
In-Reply-To: <496FB662.6080806@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Anthony Liguori wrote:

> This breaks the build.
> 
> /home/anthony/svn/qemu/hw/ssd0303.c: In function ‘ssd0303_init’:
> /home/anthony/svn/qemu/hw/ssd0303.c:320: warning: passing argument 1 of
> ‘graphic_console_init’ from incompatible pointer type
> /home/anthony/svn/qemu/hw/ssd0303.c:320: warning: passing argument 3 of
> ‘graphic_console_init’ from incompatible pointer type
> /home/anthony/svn/qemu/hw/ssd0303.c:320: error: too many arguments to
> function ‘graphic_console_init’
> /home/anthony/svn/qemu/hw/ssd0303.c:320: warning: assignment from
> incompatible pointer type
> /home/anthony/svn/qemu/hw/ssd0303.c:321: warning: passing argument 1 of
> ‘qemu_console_resize’ from incompatible pointer type
> 

PATCH 5 requires PATCH 6 and 7 to compile, where PATCH 6 and 7 are just
mindless substitutions.
Unfortunately it seems that there are problems applying 6 and 7 with the
current qemu code but rediffing them shouldn't be a problem (since they
are just substitutions).
I'll try to help you with that.