From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNmvr-0003JU-MV
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 06:32:11 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNmvp-0003Ij-Nl
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 06:32:11 -0500
Received: from [199.232.76.173] (port=36979 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNmvp-0003IX-Iu
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 06:32:09 -0500
Received: from gecko.sbs.de ([194.138.37.40]:21004)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1LNmvp-0001lD-1E
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 06:32:09 -0500
Received: from mail2.sbs.de (localhost [127.0.0.1])
	by gecko.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0GBW3J1020438
	for <qemu-devel@nongnu.org>; Fri, 16 Jan 2009 12:32:05 +0100
Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167]
	(may be forged))
	by mail2.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id n0GBW3fR003507
	for <qemu-devel@nongnu.org>; Fri, 16 Jan 2009 12:32:03 +0100
Message-ID: <49707035.2000606@siemens.com>
Date: Fri, 16 Jan 2009 12:32:05 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <49705BCF.8020506@siemens.com>
	<761ea48b0901160220o371db87m94c4ad83a2f65a09@mail.gmail.com>
In-Reply-To: <761ea48b0901160220o371db87m94c4ad83a2f65a09@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RESEND][PATCH 1/2] Log reset events
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Laurent Desnogues wrote:
> On Fri, Jan 16, 2009 at 11:05 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> [...]
>> This patch introduces a flag to log CPU resets. Useful for tracing
>> unexpected resets (such as those triggered by x86 triple faults).
> 
> [...]
> 
>> diff --git a/target-arm/helper.c b/target-arm/helper.c
>> index 81663c8..90421bb 100644
>> --- a/target-arm/helper.c
>> +++ b/target-arm/helper.c
>> @@ -159,6 +159,12 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t id)
>>  void cpu_reset(CPUARMState *env)
>>  {
>>     uint32_t id;
>> +
>> +    if (loglevel & CPU_LOG_RESET) {
>> +        fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index);
>> +        cpu_dump_state(env, logfile, fprintf, 0);
>> +    }
> 
> You should use the new log API which has been introduced yesterday
> (look in qemu-common.h).
> 

Oh, OK, will check this.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 26
Corporate Competence Center Embedded Linux