From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNpg7-0004aa-4G
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 09:28:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNpg5-0004Yw-B7
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 09:28:06 -0500
Received: from [199.232.76.173] (port=55428 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNpg4-0004Yj-Un
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 09:28:05 -0500
Received: from mail-gx0-f17.google.com ([209.85.217.17]:33993)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LNpg4-00077W-PI
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 09:28:04 -0500
Received: by gxk10 with SMTP id 10so438485gxk.10
	for <qemu-devel@nongnu.org>; Fri, 16 Jan 2009 06:28:04 -0800 (PST)
Message-ID: <49709967.2070701@codemonkey.ws>
Date: Fri, 16 Jan 2009 08:27:51 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [6322] add a -vga none cli option (Stefano
	Stabellini)
References: <E1LNYy0-0004JC-On@cvs.savannah.gnu.org>
	<49705B73.9060103@siemens.com>
In-Reply-To: <49705B73.9060103@siemens.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jan Kiszka wrote:
> This hunk now generates:
>
> qemu/hw/pc.c: In function ‘pc_init1’:
> qemu/hw/pc.c:762: warning: ‘vga_bios_offset’ may be used uninitialized in this function                                                                                                       
>
> For obvious reasons. Can we simply make the related
> cpu_register_physical_memory conditional as well?
>   

Yup, fixed now.  Thanks.

Regards,

Anthony Liguori

> Jan
>
>