From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNtm4-0008HV-0s
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:50:32 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNtm2-0008HH-4y
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:50:31 -0500
Received: from [199.232.76.173] (port=57493 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNtm2-0008HE-2T
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:50:30 -0500
Received: from qw-out-1920.google.com ([74.125.92.147]:48744)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LNtm1-0005w0-NW
	for qemu-devel@nongnu.org; Fri, 16 Jan 2009 13:50:29 -0500
Received: by qw-out-1920.google.com with SMTP id 5so376202qwc.4
	for <qemu-devel@nongnu.org>; Fri, 16 Jan 2009 10:50:28 -0800 (PST)
Message-ID: <4970D6EA.2020700@codemonkey.ws>
Date: Fri, 16 Jan 2009 12:50:18 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6343] Fix false positive for AIO on OpenBSD
References: <E1LNtCH-0000b3-5e@cvs.savannah.gnu.org>	<4970D2EE.8060206@codemonkey.ws>
	<f43fc5580901161041v52bd5be6u74f00d8a3e1e1e8b@mail.gmail.com>
In-Reply-To: <f43fc5580901161041v52bd5be6u74f00d8a3e1e1e8b@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
> On 1/16/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> Blue Swirl wrote:
>>
>>     
>>> Revision: 6343
>>>
>>>       
>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6343
>>     
>>> Author:   blueswir1
>>> Date:     2009-01-16 18:13:32 +0000 (Fri, 16 Jan 2009)
>>>
>>> Log Message:
>>> -----------
>>> Fix false positive for AIO on OpenBSD
>>>
>>>
>>>       
>>  If OpenBSD doesn't have sigqueue, we could just replace it with kill.  I
>> don't think we need to disable AIO.
>>     
>
> struct sigevent is also missing, is that a problem?
>   

It's just used for assigning the signal value.  We could have a #ifdef 
HAVE_SIGEVENT and define it if it doesn't exist--or just change the 
aioinit structure to use an int instead of the struct sigevent 
structure.  It's sigevent for glibc compatibility but that's not really 
important at this stage.

Regards,

Anthony Liguori