From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6324] Return -errno on write failure (Gleb Natapov)
Date: Fri, 16 Jan 2009 13:31:26 -0600 [thread overview]
Message-ID: <4970E08E.5010707@codemonkey.ws> (raw)
In-Reply-To: <4913173279-BeMail@laptop>
François Revol wrote:
> The maintainer of our port didn't submit patches because he was too
> busy to clean it up AFAIK.
> I'm not even sure it'd still build on BeOS, but that'd certainly help
> building in Haiku.
>
>
>> So I'm not inclined to change code that conforms to ANSI unless
>> someone
>> puts the work into supporting BeOS in mainline QEMU and that said
>> work
>> doesn't require very invasive changes.
>>
>
> As per other ports, it's not invasive it's just a large diff and it's
> fastidious to make sure each and every occurence is fixed.
>
Which is a good encouragement to invest the time in pushing your work
upstream. It's unfair to ask upstream QEMU to make changes to make
external ports simpler to maintain though.
Regards,
Anthony Liguori
> something like:
> http://revolf.free.fr/beos/patches/ffmpeg_beos_cleanup.002.diff
> or
> http://revolf.free.fr/beos/patches/oss-hg-365-beos.diff.txt
>
> François.
>
>
>
next prev parent reply other threads:[~2009-01-16 19:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 20:44 [Qemu-devel] [6324] Return -errno on write failure (Gleb Natapov) Anthony Liguori
2009-01-15 21:20 ` François Revol
2009-01-15 22:15 ` M. Warner Losh
2009-01-15 22:33 ` François Revol
2009-01-16 7:31 ` Gleb Natapov
2009-01-16 17:37 ` Ian Jackson
2009-01-16 18:36 ` François Revol
2009-01-16 18:49 ` Anthony Liguori
2009-01-16 19:17 ` François Revol
2009-01-16 19:31 ` Anthony Liguori [this message]
2009-01-16 19:41 ` François Revol
2009-01-19 11:37 ` Ian Jackson
2009-01-19 18:52 ` François Revol
2009-01-19 19:47 ` Lennart Sorensen
2009-01-19 20:31 ` François Revol
2009-01-19 20:03 ` M. Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4970E08E.5010707@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).