From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNuPs-0007Vv-SJ for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:31:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNuPr-0007Us-NF for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:31:40 -0500 Received: from [199.232.76.173] (port=56807 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNuPr-0007Ui-Hi for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:31:39 -0500 Received: from mail-qy0-f20.google.com ([209.85.221.20]:33922) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNuPr-0002mK-7H for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:31:39 -0500 Received: by qyk13 with SMTP id 13so2697922qyk.10 for ; Fri, 16 Jan 2009 11:31:38 -0800 (PST) Message-ID: <4970E08E.5010707@codemonkey.ws> Date: Fri, 16 Jan 2009 13:31:26 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [6324] Return -errno on write failure (Gleb Natapov) References: <4913173279-BeMail@laptop> In-Reply-To: <4913173279-BeMail@laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org François Revol wrote: > The maintainer of our port didn't submit patches because he was too > busy to clean it up AFAIK. > I'm not even sure it'd still build on BeOS, but that'd certainly help > building in Haiku. > > >> So I'm not inclined to change code that conforms to ANSI unless >> someone >> puts the work into supporting BeOS in mainline QEMU and that said >> work >> doesn't require very invasive changes. >> > > As per other ports, it's not invasive it's just a large diff and it's > fastidious to make sure each and every occurence is fixed. > Which is a good encouragement to invest the time in pushing your work upstream. It's unfair to ask upstream QEMU to make changes to make external ports simpler to maintain though. Regards, Anthony Liguori > something like: > http://revolf.free.fr/beos/patches/ffmpeg_beos_cleanup.002.diff > or > http://revolf.free.fr/beos/patches/oss-hg-365-beos.diff.txt > > François. > > >