From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNwTa-0000ys-4y for qemu-devel@nongnu.org; Fri, 16 Jan 2009 16:43:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNwTY-0000wN-NK for qemu-devel@nongnu.org; Fri, 16 Jan 2009 16:43:37 -0500 Received: from [199.232.76.173] (port=47260 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNwTY-0000w9-9S for qemu-devel@nongnu.org; Fri, 16 Jan 2009 16:43:36 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:57107) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNwTX-0000zW-FL for qemu-devel@nongnu.org; Fri, 16 Jan 2009 16:43:35 -0500 Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166]) by fmmailgate01.web.de (Postfix) with ESMTP id 34E4DFBD1E88 for ; Fri, 16 Jan 2009 22:43:33 +0100 (CET) Received: from [88.65.43.148] (helo=[192.168.1.198]) by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #277) id 1LNwTV-0002US-00 for qemu-devel@nongnu.org; Fri, 16 Jan 2009 22:43:33 +0100 Message-ID: <4970FF7D.5000707@web.de> Date: Fri, 16 Jan 2009 22:43:25 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig18A59A1E915D3709C8E54A1F" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [6352] Fix character devices after DisplayState refactoring Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig18A59A1E915D3709C8E54A1F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Revision: 6352 > http://svn.sv.gnu.org/viewvc/?view=3Drev&root=3Dqemu&revision= =3D6352 > Author: aliguori > Date: 2009-01-16 20:23:27 +0000 (Fri, 16 Jan 2009) >=20 > Log Message: > ----------- > Fix character devices after DisplayState refactoring >=20 > The DisplayState refactoring changed the machine init function to creat= e a > DisplayState for each VGA device instead of being passed an existing > DisplayState. This change is critical to enable multiple graphics devi= ce > support. >=20 > Unfortunately, the serial/parallel/console code is structured today to = run > before machine init to fill out the CharDriverState table which the mac= hine > init function uses to determine whether to create the required devices.= >=20 > Since a 'vc' is a type of CharDriverState, the CharDriverState code req= uires > that a DisplayState exist before it runs creating a circular dependency= =2E >=20 > To fix this, this splits the creation of the initial CharDriverState fr= om > the initialization of the text console. We can then in a second step a= ssociate > a DisplayState with all TextConsoles. This allows us to create the > CharDriverState's first, machine init, then associate the TextConsoles = with > a DisplayState. >=20 > This code screams for more cleanup. =2E..and a fix to make the monitor show up on the second vc again. Any immediate idea what went wrong? Jan --------------enig18A59A1E915D3709C8E54A1F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAklw/4cACgkQniDOoMHTA+ngwACfbyu8Ylfg4y+0+TMpDyj2khBd tHAAn1tx14ahkZPmo18/ClJ639CQnrOB =HJ+L -----END PGP SIGNATURE----- --------------enig18A59A1E915D3709C8E54A1F--