From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] qapi: make machine type deprecation a warning
Date: Thu, 12 May 2022 14:24:35 +0200 [thread overview]
Message-ID: <4970cd1d-6801-9a57-04a7-1e907c1b7fcf@redhat.com> (raw)
In-Reply-To: <87a6bn9gg3.fsf@pond.sub.org>
On 5/12/22 12:46, Markus Armbruster wrote:
> Commit message nitpick: not sure this is "qapi:". The commit that
> introduced "Machine type ... is deprecated" (08fe68244eb) used
> "hw/i386:". We commonly use "vl:", "softmmu:", and "softmmu/vl:" for
> this file.
Will do.
I wonder if I should already propose renaming vl.c to climain.c, even if
there's no qmpmain.c yet. Emotional/historical attachment is probably
not good enough of a reason to keep that name.
I suppose this is already a proposal.
Paolo
next prev parent reply other threads:[~2022-05-12 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 17:50 [PATCH] qapi: make machine type deprecation a warning Paolo Bonzini
2022-05-11 18:44 ` Markus Armbruster
2022-05-12 8:26 ` Paolo Bonzini
2022-05-12 9:44 ` Markus Armbruster
2022-05-12 10:46 ` Markus Armbruster
2022-05-12 12:24 ` Paolo Bonzini [this message]
2022-05-12 12:53 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4970cd1d-6801-9a57-04a7-1e907c1b7fcf@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).