Re: [Qemu-devel] Re: [6352] Fix character devices after DisplayState refactoring

[Anthony Liguori <anthony@codemonkey.ws>]

Jan Kiszka wrote:
> Anthony Liguori wrote:
>   
>> Revision: 6352
>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6352
>> Author:   aliguori
>> Date:     2009-01-16 20:23:27 +0000 (Fri, 16 Jan 2009)
>>
>> Log Message:
>> -----------
>> Fix character devices after DisplayState refactoring
>>
>> The DisplayState refactoring changed the machine init function to create a
>> DisplayState for each VGA device instead of being passed an existing
>> DisplayState.  This change is critical to enable multiple graphics device
>> support.
>>
>> Unfortunately, the serial/parallel/console code is structured today to run
>> before machine init to fill out the CharDriverState table which the machine
>> init function uses to determine whether to create the required devices.
>>
>> Since a 'vc' is a type of CharDriverState, the CharDriverState code requires
>> that a DisplayState exist before it runs creating a circular dependency.
>>
>> To fix this, this splits the creation of the initial CharDriverState from
>> the initialization of the text console.  We can then in a second step associate
>> a DisplayState with all TextConsoles.  This allows us to create the
>> CharDriverState's first, machine init, then associate the TextConsoles with
>> a DisplayState.
>>
>> This code screams for more cleanup.
>>     
>
> ...and a fix to make the monitor show up on the second vc again.

Just got that one.

>  Any immediate idea what went wrong?
>   

Not enough testing.

Regards,

Anthony Liguori

> Jan
>
>