From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNwec-0003aG-MB for qemu-devel@nongnu.org; Fri, 16 Jan 2009 16:55:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNwea-0003YO-O8 for qemu-devel@nongnu.org; Fri, 16 Jan 2009 16:55:02 -0500 Received: from [199.232.76.173] (port=55885 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNwea-0003YC-JT for qemu-devel@nongnu.org; Fri, 16 Jan 2009 16:55:00 -0500 Received: from yx-out-1718.google.com ([74.125.44.154]:26391) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNwea-0002YT-5R for qemu-devel@nongnu.org; Fri, 16 Jan 2009 16:55:00 -0500 Received: by yx-out-1718.google.com with SMTP id 3so739524yxi.82 for ; Fri, 16 Jan 2009 13:54:59 -0800 (PST) Message-ID: <49710224.5050807@codemonkey.ws> Date: Fri, 16 Jan 2009 15:54:44 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [6352] Fix character devices after DisplayState refactoring References: <4970FF7D.5000707@web.de> In-Reply-To: <4970FF7D.5000707@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jan Kiszka wrote: > Anthony Liguori wrote: > >> Revision: 6352 >> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6352 >> Author: aliguori >> Date: 2009-01-16 20:23:27 +0000 (Fri, 16 Jan 2009) >> >> Log Message: >> ----------- >> Fix character devices after DisplayState refactoring >> >> The DisplayState refactoring changed the machine init function to create a >> DisplayState for each VGA device instead of being passed an existing >> DisplayState. This change is critical to enable multiple graphics device >> support. >> >> Unfortunately, the serial/parallel/console code is structured today to run >> before machine init to fill out the CharDriverState table which the machine >> init function uses to determine whether to create the required devices. >> >> Since a 'vc' is a type of CharDriverState, the CharDriverState code requires >> that a DisplayState exist before it runs creating a circular dependency. >> >> To fix this, this splits the creation of the initial CharDriverState from >> the initialization of the text console. We can then in a second step associate >> a DisplayState with all TextConsoles. This allows us to create the >> CharDriverState's first, machine init, then associate the TextConsoles with >> a DisplayState. >> >> This code screams for more cleanup. >> > > ...and a fix to make the monitor show up on the second vc again. Just got that one. > Any immediate idea what went wrong? > Not enough testing. Regards, Anthony Liguori > Jan > >