From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOJOC-0007gQ-BP for qemu-devel@nongnu.org; Sat, 17 Jan 2009 17:11:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOJOA-0007fK-Gn for qemu-devel@nongnu.org; Sat, 17 Jan 2009 17:11:35 -0500 Received: from [199.232.76.173] (port=34010 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOJOA-0007fB-8P for qemu-devel@nongnu.org; Sat, 17 Jan 2009 17:11:34 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:65487) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LOJO9-0000rh-NO for qemu-devel@nongnu.org; Sat, 17 Jan 2009 17:11:34 -0500 Message-ID: <4972578E.5000705@mail.berlios.de> Date: Sat, 17 Jan 2009 23:11:26 +0100 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [6352] Fix character devices after DisplayState refactoring References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Anthony Liguori Anthony Liguori schrieb: > Revision: 6352 > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6352 > Author: aliguori > Date: 2009-01-16 20:23:27 +0000 (Fri, 16 Jan 2009) > > Log Message: > ----------- > Fix character devices after DisplayState refactoring > > The DisplayState refactoring changed the machine init function to create a > DisplayState for each VGA device instead of being passed an existing > DisplayState. This change is critical to enable multiple graphics device > support. > > Unfortunately, the serial/parallel/console code is structured today to run > before machine init to fill out the CharDriverState table which the > machine > init function uses to determine whether to create the required devices. > > Since a 'vc' is a type of CharDriverState, the CharDriverState code > requires > that a DisplayState exist before it runs creating a circular dependency. > > To fix this, this splits the creation of the initial CharDriverState from > the initialization of the text console. We can then in a second step > associate > a DisplayState with all TextConsoles. This allows us to create the > CharDriverState's first, machine init, then associate the TextConsoles > with > a DisplayState. > > This code screams for more cleanup. Yes, it screams for more cleanups. MIPS Malta also no longer works, same reason as for the serial code: Malta creates a character device during machine init and writes some characters to it. This is now impossible because qemu_chr_printf can no longer be called before text_consoles_set_display was called. Regards Stefan Weil