From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOWwR-0007e2-0B for qemu-devel@nongnu.org; Sun, 18 Jan 2009 07:39:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOWwP-0007dq-9Z for qemu-devel@nongnu.org; Sun, 18 Jan 2009 07:39:50 -0500 Received: from [199.232.76.173] (port=37476 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOWwP-0007dn-3p for qemu-devel@nongnu.org; Sun, 18 Jan 2009 07:39:49 -0500 Received: from mx2.redhat.com ([66.187.237.31]:57232) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LOWwO-0001Ht-Kp for qemu-devel@nongnu.org; Sun, 18 Jan 2009 07:39:48 -0500 Message-ID: <4973230D.9010104@redhat.com> Date: Sun, 18 Jan 2009 14:39:41 +0200 From: Uri Lublin MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu-img: adding a "-F base_fmt" option to "qemu-img create -b" References: <1231677493-30924-1-git-send-email-uril@redhat.com> <496F93B1.5090001@codemonkey.ws> In-Reply-To: <496F93B1.5090001@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Anthony Liguori wrote: >> From: Uri Lublin >> >> If the user specifies the backing file format, >> then when opening the backing file, there is no need >> to probe the (backing file) image to figure out its format. >> >> This follows my previous patch implementing fmt:FMT: prefix for backing >> filename. >> > > But how does this work in the absence of supporting fmt:FMT? Does this > imply that the other patch is needed too? > Yes, This patch only has meaning if the fmt:FMT: patch is accepted. Its purpose is to give the user a way to specify the backing file format ('-F FMT') without using specific implementation details (prefixing the backing-file filename with 'fmt:FMT:' ) Suggested by Daniel P. Berrange. Thanks, Uri.