From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LOsKA-0007iu-Gx
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 06:29:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LOsK9-0007if-Rc
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 06:29:45 -0500
Received: from [199.232.76.173] (port=46780 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LOsK9-0007ic-Md
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 06:29:45 -0500
Received: from smtp.eu.citrix.com ([62.200.22.115]:51647)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LOsK9-0005Ym-0C
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 06:29:45 -0500
Message-ID: <49746372.8070703@eu.citrix.com>
Date: Mon, 19 Jan 2009 11:26:42 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6352] Fix character devices after DisplayState
	refactoring
References: <E1LNvE0-00076q-JF@cvs.savannah.gnu.org>
In-Reply-To: <E1LNvE0-00076q-JF@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:

> Revision: 6352
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6352
> Author:   aliguori
> Date:     2009-01-16 20:23:27 +0000 (Fri, 16 Jan 2009)
> 
> Log Message:
> -----------
> Fix character devices after DisplayState refactoring
> 
> The DisplayState refactoring changed the machine init function to create a
> DisplayState for each VGA device instead of being passed an existing
> DisplayState.  This change is critical to enable multiple graphics device
> support.
> 
> Unfortunately, the serial/parallel/console code is structured today to run
> before machine init to fill out the CharDriverState table which the machine
> init function uses to determine whether to create the required devices.
> 
> Since a 'vc' is a type of CharDriverState, the CharDriverState code requires
> that a DisplayState exist before it runs creating a circular dependency.
> 
> To fix this, this splits the creation of the initial CharDriverState from
> the initialization of the text console.  We can then in a second step associate
> a DisplayState with all TextConsoles.  This allows us to create the
> CharDriverState's first, machine init, then associate the TextConsoles with
> a DisplayState.
> 
> This code screams for more cleanup.
> 

I am sorry for this.

While I was testing the patch series I was expecting many rendering
issues or console switching issues: once I saw that both the serial and
parallel port consoles were present I didn't check they were actually
working.