From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LOw8i-0008Fy-Rx
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 10:34:12 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LOw8h-0008F2-Gj
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 10:34:12 -0500
Received: from [199.232.76.173] (port=45460 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LOw8h-0008Ez-74
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 10:34:11 -0500
Received: from smtp.eu.citrix.com ([62.200.22.115]:37829)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LOw8g-00073f-Q3
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 10:34:10 -0500
Message-ID: <49749CB7.1020508@eu.citrix.com>
Date: Mon, 19 Jan 2009 15:31:03 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [PATCH] Adds null check for DisplayStatus (wasRe: [Qemu-devel]
	[6344]	graphical_console_init change	(Stefano	Stabellini)
References: <E1LNtzL-0002pj-7r@cvs.savannah.gnu.org>	<4973267B.9010901@juno.dti.ne.jp>	<49734152.7080302@juno.dti.ne.jp>	<49746680.3070400@eu.citrix.com>
	<49749B91.6080200@juno.dti.ne.jp>
In-Reply-To: <49749B91.6080200@juno.dti.ne.jp>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Shin-ichiro KAWASAKI wrote:

> Stefano Stabellini wrote:
>> Shin-ichiro KAWASAKI wrote:
>>
>>> I'm sending the patch which solves the problem above.
>>> Could anyone evaluate it?
>>>
>>
>>
>>
>> Thanks for spotting the bug and your work on a patch!
>>
>> However I think the following fix is cleaner: we do not need a
>> dumb_display_init that creates an empty DisplayChangeListener any more.
>> We do need a dumb_display_init that allocates a zeroed DisplayState
>> structure if none else does it.
>>
>> Please let me know if it also fixes you problem.
> 
> It solves my problem finely.  Thank you!
> 
> Tested-by: Shin-ichiro KAWASAKI <kawasaki@juno.dti.ne.jp>
> 

Thanks for testing it.
Anthony, before committing this patch, check out the other equivalent
patch I sent as I reply to 'add a -vga none cli option'.