qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH v3] Stop VM on ENOSPC error.
Date: Mon, 19 Jan 2009 10:15:00 -0600	[thread overview]
Message-ID: <4974A704.3070605@codemonkey.ws> (raw)
In-Reply-To: <18804.27240.886522.337700@mariner.uk.xensource.com>

Ian Jackson wrote:
> Gleb Natapov writes ("[Qemu-devel] [PATCH v3] Stop VM on ENOSPC error."):
>   
>> And repeat last IDE command after VM restart.
>>     
>
> Once again, this feature should be optional.
>   

Why?

I'm not looking to have a long discussion on the merits one way or 
another, but I'd at least like to know why you would want to disable 
this in Xen.

Assuming this comes along with some way to detect when the VM has been 
stopped by this condition programmatically, Xend could simply cont if it 
cared to ignore the error?  I guess it would then get stuck in an 
infinite loop.  But why would you ignore the error in the first place?

Regards,

Anthony Liguori

> Personally I would think it should be off by default.  While that's a
> holy war, I think it's clear that it needs to be configurable,
> probably with a command-line option.
>
> Ian.
>
>
>   

  parent reply	other threads:[~2009-01-19 16:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18 11:05 [Qemu-devel] [PATCH v3] Stop VM on ENOSPC error Gleb Natapov
2009-01-19 11:56 ` Ian Jackson
2009-01-19 12:16   ` Gleb Natapov
2009-01-19 16:15   ` Anthony Liguori [this message]
2009-01-19 17:22     ` Ian Jackson
2009-01-19 18:38       ` Avi Kivity
2009-01-19 18:41       ` Gleb Natapov
2009-01-20  9:25       ` Gerd Hoffmann
2009-01-20  9:35         ` Gleb Natapov
2009-01-20 10:44           ` Carl-Daniel Hailfinger
2009-01-20 11:05             ` Gleb Natapov
2009-01-20 11:35       ` Vincent Hanquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4974A704.3070605@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).