From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOwmS-0001mF-I9 for qemu-devel@nongnu.org; Mon, 19 Jan 2009 11:15:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOwmQ-0001j8-Ps for qemu-devel@nongnu.org; Mon, 19 Jan 2009 11:15:16 -0500 Received: from [199.232.76.173] (port=55412 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOwmQ-0001ip-Jq for qemu-devel@nongnu.org; Mon, 19 Jan 2009 11:15:14 -0500 Received: from mail-qy0-f20.google.com ([209.85.221.20]:41762) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LOwmQ-00036Z-Bu for qemu-devel@nongnu.org; Mon, 19 Jan 2009 11:15:14 -0500 Received: by qyk13 with SMTP id 13so4117571qyk.10 for ; Mon, 19 Jan 2009 08:15:13 -0800 (PST) Message-ID: <4974A704.3070605@codemonkey.ws> Date: Mon, 19 Jan 2009 10:15:00 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3] Stop VM on ENOSPC error. References: <20090118110509.GG11299@redhat.com> <18804.27240.886522.337700@mariner.uk.xensource.com> In-Reply-To: <18804.27240.886522.337700@mariner.uk.xensource.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Ian Jackson Ian Jackson wrote: > Gleb Natapov writes ("[Qemu-devel] [PATCH v3] Stop VM on ENOSPC error."): > >> And repeat last IDE command after VM restart. >> > > Once again, this feature should be optional. > Why? I'm not looking to have a long discussion on the merits one way or another, but I'd at least like to know why you would want to disable this in Xen. Assuming this comes along with some way to detect when the VM has been stopped by this condition programmatically, Xend could simply cont if it cared to ignore the error? I guess it would then get stuck in an infinite loop. But why would you ignore the error in the first place? Regards, Anthony Liguori > Personally I would think it should be off by default. While that's a > holy war, I think it's clear that it needs to be configurable, > probably with a command-line option. > > Ian. > > >