From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOx5L-0000cE-7i for qemu-devel@nongnu.org; Mon, 19 Jan 2009 11:34:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOx5K-0000bv-Dr for qemu-devel@nongnu.org; Mon, 19 Jan 2009 11:34:46 -0500 Received: from [199.232.76.173] (port=47210 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOx5K-0000bq-4I for qemu-devel@nongnu.org; Mon, 19 Jan 2009 11:34:46 -0500 Received: from yw-out-2324.google.com ([74.125.46.31]:29211) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LOx5J-0004ij-Qu for qemu-devel@nongnu.org; Mon, 19 Jan 2009 11:34:45 -0500 Received: by yw-out-2324.google.com with SMTP id 2so978714ywt.45 for ; Mon, 19 Jan 2009 08:34:44 -0800 (PST) Message-ID: <4974AB98.5030507@codemonkey.ws> Date: Mon, 19 Jan 2009 10:34:32 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [PATCH] Adds null check for DisplayStatus (wasRe: [Qemu-devel] [6344] graphical_console_init change (Stefano Stabellini) References: <4973267B.9010901@juno.dti.ne.jp> <49734152.7080302@juno.dti.ne.jp> <49746680.3070400@eu.citrix.com> In-Reply-To: <49746680.3070400@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefano Stabellini wrote: > Shin-ichiro KAWASAKI wrote: > > >> I'm sending the patch which solves the problem above. >> Could anyone evaluate it? >> >> > > > > Thanks for spotting the bug and your work on a patch! > > However I think the following fix is cleaner: we do not need a > dumb_display_init that creates an empty DisplayChangeListener any more. > We do need a dumb_display_init that allocates a zeroed DisplayState > structure if none else does it. > > Please let me know if it also fixes you problem. > > Signed-off-by: Stefano Stabellini > Applied. Thanks. Regards, Anthony Liguori