From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOxmM-0001QQ-Sj for qemu-devel@nongnu.org; Mon, 19 Jan 2009 12:19:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOxmL-0001Py-Hn for qemu-devel@nongnu.org; Mon, 19 Jan 2009 12:19:14 -0500 Received: from [199.232.76.173] (port=42782 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOxmL-0001Pr-Ba for qemu-devel@nongnu.org; Mon, 19 Jan 2009 12:19:13 -0500 Received: from mx2.redhat.com ([66.187.237.31]:48353) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LOxmK-00015U-L0 for qemu-devel@nongnu.org; Mon, 19 Jan 2009 12:19:12 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0JHJBcv009563 for ; Mon, 19 Jan 2009 12:19:11 -0500 Message-ID: <4974B60A.8080003@redhat.com> Date: Mon, 19 Jan 2009 19:19:06 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/5] Vectored block device API References: <1232308399-21679-1-git-send-email-avi@redhat.com> <1232308399-21679-4-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Blue Swirl wrote: >> +static void flatten_iovec(VectorTranslationState *s) >> +static void unflatten_iovec(VectorTranslationState *s) >> > I think these should be moved to vl.c together with patch 4 stuff, > they are not block device specific. > Agree. Further, they should accept a QEMUIOVector (as should the bdrvv API). -- error compiling committee.c: too many arguments to function