From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LOzTp-0004F6-LL
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 14:08:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LOzTo-0004EP-H0
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 14:08:12 -0500
Received: from [199.232.76.173] (port=48680 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LOzTn-0004EM-Rv
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 14:08:11 -0500
Received: from mail-qy0-f20.google.com ([209.85.221.20]:50601)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LOzTn-00059S-Fb
	for qemu-devel@nongnu.org; Mon, 19 Jan 2009 14:08:11 -0500
Received: by qyk13 with SMTP id 13so4203949qyk.10
	for <qemu-devel@nongnu.org>; Mon, 19 Jan 2009 11:08:08 -0800 (PST)
Message-ID: <4974CF8B.5080409@codemonkey.ws>
Date: Mon, 19 Jan 2009 13:07:55 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [PATCH] Adds null check for DisplayStatus (wasRe: [Qemu-devel]
	[6344]	graphical_console_init change	(Stefano	Stabellini)
References: <E1LNtzL-0002pj-7r@cvs.savannah.gnu.org>	<4973267B.9010901@juno.dti.ne.jp>	<49734152.7080302@juno.dti.ne.jp>	<49746680.3070400@eu.citrix.com>	<49749B91.6080200@juno.dti.ne.jp>	<49749CB7.1020508@eu.citrix.com>	<4974A593.1020607@codemonkey.ws>
	<4974A802.7080506@eu.citrix.com>
In-Reply-To: <4974A802.7080506@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefano Stabellini wrote:
> Anthony Liguori wrote:
>
>   
>> Stefano Stabellini wrote:
>>     
>>> Thanks for testing it.
>>> Anthony, before committing this patch, check out the other equivalent
>>> patch I sent as I reply to 'add a -vga none cli option'.
>>>   
>>>       
>> Hi Stefan,
>>
>> Are you working on a fix for the SEGV when not using -nographic?  If I run:
>>
>> qemu -hda image.foo -snapshot -vga none
>>
>> I get a segv b/c SDL_SetVideoMode() uses ds_get_width/height and
>> ds->surface == NULL.
>>
>>     
>
>
>
> Yes, the complete fix is the following, it also solves the other bug that
> arises when you set -vga none but you do not specify -nographic:
>
>   
I already applied your first.  Can you send a diff against SVN along 
with a Signed-off-by line?

Thanks,

Anthony Liguori
>
>