From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2272BC4345F for ; Tue, 16 Apr 2024 19:59:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwows-0003Bj-1h; Tue, 16 Apr 2024 15:58:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwowp-0003Ax-Ro for qemu-devel@nongnu.org; Tue, 16 Apr 2024 15:58:31 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwowo-0006cI-7y for qemu-devel@nongnu.org; Tue, 16 Apr 2024 15:58:31 -0400 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5e8470c1cb7so3222735a12.2 for ; Tue, 16 Apr 2024 12:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713297508; x=1713902308; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0fj1TtsmLXFU5zeTrIW6IYpbVwDQn1C8BlLXoejuuEg=; b=r1kO6ezqLIOhO6DUb38ZHR9B39yX+ZrTr+SFqxjvQ8lV13sObZ5AkbaEO97eB005Gn 75+Uw2D8i5MkwgcVrgO/dVRQsHiNSFNnmYvHNN+Q3DqnZnYs1QcpVzKxysK5FxjGiTvd vw1tvHR1WIL8lS9fQC+Nw7HGODlo0OTzi0I0eoO3xyzLj+fLHjbAL9ptU8ZtKPM/WNN1 WnY5hVSyIKPMsM3z2wrgdFubeoz56QjTxmC8W06oWkX+kTWkVpRo3iN19QeB7uEEAIzD naXdpLJvh/j+Q5DWyHiPJa98pYiWJGF33a1N6Qgy+5Wv6yfd5iIwfbS0T1DtLqttzE5+ ZVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713297508; x=1713902308; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0fj1TtsmLXFU5zeTrIW6IYpbVwDQn1C8BlLXoejuuEg=; b=DcyRz2LolmATL9N12RUoiBQjCCy/vMZSnXQaMBNOOl9wbZ43gGy2u6SBNkjqUZ1nYH yaYxewWTvja0R6CSDDAZt08eEX8bkKlm6Jsivamwun2utsSiopetUn+8dGy1aZ7oqDBn 2kXE2r59zB8USD8jfLhu6E0rzH8ZN0wGd7sjredj6IAyNle3S7pJzrgrnV7odOgVegrI OL6E6MtvEcsXnwKKM9ZR0mEtm6yGorExwP0d2MIpJImFGMOZ9c0+tNYGWCRoCsD3gDX5 u9tZn8Zndvp+DKLDgfN6abf+cjWu5R1mgH0izJ7BvvRk28/uev1vdu3y98CBB9Gd8doV EwGA== X-Forwarded-Encrypted: i=1; AJvYcCXz49PKjo4rjvc83jdaasw6jqLFNjEZ0wgOcfkaeihgfegmG316Y59QeZHRF802VvfVWUJ6l3/ZwNJNy97yyWTzXpb0xxY= X-Gm-Message-State: AOJu0Yxdho9BDSmnRpb1wWM/SzsDx9IpsSisiMangfxsm2lUHnoH+Tid vzk/g9yp24LOasX1esGLatEsqWYudOaFopZ1ATjY6EiXNWdnClhkVKB4fPJWAdY= X-Google-Smtp-Source: AGHT+IEHIrxJd2UYdYuVQft9ZX3BU2XoAfE3Z5gsO3cu2Mg5HW03emwF6eYYFcjaZ49nnKIuqBQoCA== X-Received: by 2002:a17:90a:b96:b0:2a0:9b66:8e22 with SMTP id 22-20020a17090a0b9600b002a09b668e22mr10449738pjr.24.1713297508361; Tue, 16 Apr 2024 12:58:28 -0700 (PDT) Received: from [192.168.0.4] (174-21-72-5.tukw.qwest.net. [174.21.72.5]) by smtp.gmail.com with ESMTPSA id l23-20020a17090a3f1700b002a55198259fsm1868848pjc.0.2024.04.16.12.58.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 12:58:27 -0700 (PDT) Message-ID: <4974d780-28ec-4781-8dcb-55b3fd082303@linaro.org> Date: Tue, 16 Apr 2024 12:58:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for-9.1 v2 2/2] trans_privileged.c.inc: set (m|s)tval on ebreak breakpoint To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com References: <20240416194132.1843699-1-dbarboza@ventanamicro.com> <20240416194132.1843699-3-dbarboza@ventanamicro.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20240416194132.1843699-3-dbarboza@ventanamicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/16/24 12:41, Daniel Henrique Barboza wrote: > @@ -62,6 +62,10 @@ static bool trans_ebreak(DisasContext *ctx, arg_ebreak *a) > if (pre == 0x01f01013 && ebreak == 0x00100073 && post == 0x40705013) { > generate_exception(ctx, RISCV_EXCP_SEMIHOST); > } else { > + TCGv temp = tcg_temp_new(); > + tcg_gen_movi_tl(temp, ebreak_addr); > + tcg_gen_st_tl(temp, tcg_env, offsetof(CPURISCVState, badaddr)); tcg_gen_st_tl(tcg_constant_tl(ebreak_addr), ...) r~