From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LP6Ku-0006S4-KX for qemu-devel@nongnu.org; Mon, 19 Jan 2009 21:27:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LP6Ks-0006QG-4z for qemu-devel@nongnu.org; Mon, 19 Jan 2009 21:27:27 -0500 Received: from [199.232.76.173] (port=38478 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LP6Ks-0006QD-0T for qemu-devel@nongnu.org; Mon, 19 Jan 2009 21:27:26 -0500 Received: from mail-gx0-f15.google.com ([209.85.217.15]:38889) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LP6Kr-0000zz-MW for qemu-devel@nongnu.org; Mon, 19 Jan 2009 21:27:25 -0500 Received: by gxk8 with SMTP id 8so425777gxk.10 for ; Mon, 19 Jan 2009 18:27:24 -0800 (PST) Message-ID: <49753680.8060301@codemonkey.ws> Date: Mon, 19 Jan 2009 20:27:12 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <20090116210954.16725.44321.stgit@kvm.aw> In-Reply-To: <20090116210954.16725.44321.stgit@kvm.aw> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/7] qemu:virtio-net: Add MAC and VLAN filtering Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: markmc@redhat.com, Rusty Russell , qemu-devel@nongnu.org, kvm@vger.kernel.org Any comments Rusty? I'm waiting for input on the kernel bits to apply the QEMU side of this. Regards, Anthony Liguori Alex Williamson wrote: > This series adds the ability for the guest to set the virtio-net device > MAC address, a new control virtqueue for setting configuration data from > the guest, and new interfaces making use of the control virtqueue for > setting RX mode options, MAC filter table entries, and VLAN filter bits. > The end result is that the virtio-net device has more of the features of > a realy hardware NIC and can be configured to drop packets the guest > isn't interested in seeing. > > This version incorporates the review comments from Mark McLoughlin, > particularly including much better commit logs, factoring control > commands into separate functions, and making a local ETH_ALEN define. > Also new in this version is the addition of VLAN filtering. Please > comment and/or apply. Thanks, > > Alex > > Note - This series depends on the previous patch sent to correct > save and load of the virtio-net state. > --- > > Alex Williamson (7): > qemu:virtio-net: Add VLAN filtering > qemu:virtio-net: Add additional MACs via a filter table > qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti > qemu:virtio-net: Add promiscuous and all-multicast mode bits > qemu:virtio-net: Add a virtqueue for control commands from the guest > qemu:virtio-net: Define ETH_ALEN for use when manipulating MAC addresses > qemu:virtio-net: Allow setting the MAC address via set_config > > > qemu/hw/virtio-net.c | 280 +++++++++++++++++++++++++++++++++++++++++++++++++- > qemu/hw/virtio-net.h | 61 +++++++++++ > 2 files changed, 333 insertions(+), 8 deletions(-) > >