qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] dumb_display_init() crash
Date: Tue, 20 Jan 2009 10:49:22 +0000	[thread overview]
Message-ID: <4975AC32.6030502@eu.citrix.com> (raw)
In-Reply-To: <20090119224358.12d91af1@acmay.homeip.net>

Andrew May wrote:

> This fixes a crash for the 405 boards that don't do a display init.
> I would think this is correct but I am not sure if there is more that
> needs to be setup. This at least gets me back to the SDL display I use
> to see before the re-org.

Your fix is correct, I am just going to repost your patch adding
signed-off-lines and changing the return NULL into exit(1) in case the
malloc fails.

      reply	other threads:[~2009-01-20 10:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20  6:43 [Qemu-devel] [PATCH] dumb_display_init() crash Andrew May
2009-01-20 10:49 ` Stefano Stabellini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4975AC32.6030502@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).