From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPEE9-0001ZO-QQ for qemu-devel@nongnu.org; Tue, 20 Jan 2009 05:53:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPEE7-0001Y4-1N for qemu-devel@nongnu.org; Tue, 20 Jan 2009 05:53:00 -0500 Received: from [199.232.76.173] (port=47396 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPEE6-0001Xn-Gn for qemu-devel@nongnu.org; Tue, 20 Jan 2009 05:52:58 -0500 Received: from smtp.eu.citrix.com ([62.200.22.115]:56988) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LPEE6-0006sk-33 for qemu-devel@nongnu.org; Tue, 20 Jan 2009 05:52:58 -0500 Message-ID: <4975AC32.6030502@eu.citrix.com> Date: Tue, 20 Jan 2009 10:49:22 +0000 From: Stefano Stabellini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] dumb_display_init() crash References: <20090119224358.12d91af1@acmay.homeip.net> In-Reply-To: <20090119224358.12d91af1@acmay.homeip.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Andrew May wrote: > This fixes a crash for the 405 boards that don't do a display init. > I would think this is correct but I am not sure if there is more that > needs to be setup. This at least gets me back to the SDL display I use > to see before the re-org. Your fix is correct, I am just going to repost your patch adding signed-off-lines and changing the return NULL into exit(1) in case the malloc fails.