From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPIxz-0007qS-T5 for qemu-devel@nongnu.org; Tue, 20 Jan 2009 10:56:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPIxx-0007qD-V9 for qemu-devel@nongnu.org; Tue, 20 Jan 2009 10:56:39 -0500 Received: from [199.232.76.173] (port=36336 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPIxx-0007qA-Os for qemu-devel@nongnu.org; Tue, 20 Jan 2009 10:56:37 -0500 Received: from mx2.redhat.com ([66.187.237.31]:59601) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LPIxx-0002Ic-5f for qemu-devel@nongnu.org; Tue, 20 Jan 2009 10:56:37 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0KFuZYr001704 for ; Tue, 20 Jan 2009 10:56:35 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0KFuZ3r016627 for ; Tue, 20 Jan 2009 10:56:36 -0500 Received: from zweiblum.travel.kraxel.org (vpn-10-154.str.redhat.com [10.32.10.154]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n0KFuY5Q009363 for ; Tue, 20 Jan 2009 10:56:35 -0500 Message-ID: <4975F42B.7080904@redhat.com> Date: Tue, 20 Jan 2009 16:56:27 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Adds null check for DisplayStatus References: <4973267B.9010901@juno.dti.ne.jp> <49734152.7080302@juno.dti.ne.jp> <49746680.3070400@eu.citrix.com> <49749B91.6080200@juno.dti.ne.jp> <49749CB7.1020508@eu.citrix.com> <4974A593.1020607@codemonkey.ws> <4974A802.7080506@eu.citrix.com> <4974CF8B.5080409@codemonkey.ws> <4975AD3E.8050101@eu.citrix.com> In-Reply-To: <4975AD3E.8050101@eu.citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Stefano Stabellini wrote: > Allocate a DisplaySurface in dumb_display_init if none else does it. > The DisplaySurface will be used for the qemu monitor, serial and > parallel ports, etc. Ah. That one should fix the "-vga none -vnc :0" crashes, right? Some more displaystate questions: I'm sitting here with a initialization order issue I'm not sure how to tackle best. xenfb calls graphics_console_init() once the frontend and backend finished the handshake, usually a few seconds after the guest started running. In case the guest has no framebuffer frontend driver the graphics_console_init() call doesn't happen at all. So it behaves like a hot-plugged graphics card. With the new displaystate allocation rules and dumb_display_init() in place I will end up with *two* displaystates in case I keep the setup logic this way. Is that going to work? There is a new register_displaystate() which maintains a linked list of displaystates, so it looks like it might work? Or is this work in progress? What do you suggest to do? What other patches do you have in the queue I maybe should know about when adapting xenfb? Will the text consoles (monitor, serial line, ...) continue to hitchhike on the displaystate of the graphics display? cheers, Gerd