From: Anthony Liguori <anthony@codemonkey.ws>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] migration: adding migration to/from a file
Date: Tue, 20 Jan 2009 10:26:37 -0600 [thread overview]
Message-ID: <4975FB3D.80108@codemonkey.ws> (raw)
In-Reply-To: <20090120115347.GK6004@redhat.com>
Daniel P. Berrange wrote:
> On Tue, Jan 20, 2009 at 01:32:24PM +0200, Uri Lublin wrote:
>
>>
>> I can call fcntl with F_SETFL and O_NONBLOCK.
>>
>
> IIRC that doesn't have any effect on plain files - they'll still potentially
> block on write.
>
Yes, it doesn't. I learned this the hard way with the old migration
code. When I implemented file: migration, I noticed it never worked
properly (properly being live) unless I used a rate limit. Since we
defaulted a rate limit, it seemed to work, but the true test is whether
it works in the absence of rate limiting.
Regards,
Anthony Liguori
> Daniel
>
prev parent reply other threads:[~2009-01-20 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 0:18 [Qemu-devel] [PATCH] migration: adding migration to/from a file Uri Lublin
2009-01-19 0:55 ` Paul Brook
2009-01-20 11:05 ` Uri Lublin
2009-01-20 14:06 ` Ian Jackson
2009-01-19 15:11 ` Anthony Liguori
2009-01-20 11:15 ` Daniel P. Berrange
2009-01-20 12:15 ` Uri Lublin
2009-01-20 16:24 ` Anthony Liguori
2009-01-20 11:32 ` Uri Lublin
2009-01-20 11:53 ` Daniel P. Berrange
2009-01-20 16:26 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4975FB3D.80108@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).