From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPJRE-0000jr-PJ
	for qemu-devel@nongnu.org; Tue, 20 Jan 2009 11:26:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPJRE-0000jZ-9X
	for qemu-devel@nongnu.org; Tue, 20 Jan 2009 11:26:52 -0500
Received: from [199.232.76.173] (port=38803 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPJRD-0000jT-Sd
	for qemu-devel@nongnu.org; Tue, 20 Jan 2009 11:26:51 -0500
Received: from qw-out-1920.google.com ([74.125.92.149]:1422)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LPJRD-0005UP-Je
	for qemu-devel@nongnu.org; Tue, 20 Jan 2009 11:26:51 -0500
Received: by qw-out-1920.google.com with SMTP id 5so607416qwc.4
	for <qemu-devel@nongnu.org>; Tue, 20 Jan 2009 08:26:50 -0800 (PST)
Message-ID: <4975FB3D.80108@codemonkey.ws>
Date: Tue, 20 Jan 2009 10:26:37 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] migration: adding migration to/from a file
References: <1232324325-25060-1-git-send-email-uril@redhat.com>
	<49749820.2070209@codemonkey.ws> <4975B648.5050104@redhat.com>
	<20090120115347.GK6004@redhat.com>
In-Reply-To: <20090120115347.GK6004@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

Daniel P. Berrange wrote:
> On Tue, Jan 20, 2009 at 01:32:24PM +0200, Uri Lublin wrote:
>   
>>
>> I can call fcntl with F_SETFL and O_NONBLOCK.
>>     
>
> IIRC that doesn't have any effect on plain files - they'll still potentially
> block on write.
>   

Yes, it doesn't.  I learned this the hard way with the old migration 
code.  When I implemented file: migration, I noticed it never worked 
properly (properly being live) unless I used a rate limit.  Since we 
defaulted a rate limit, it seemed to work, but the true test is whether 
it works in the absence of rate limiting.

Regards,

Anthony Liguori

> Daniel
>