* [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit
@ 2009-01-21 9:47 Liu Yu
2009-01-21 11:05 ` Stefano Stabellini
2009-01-21 15:59 ` Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Liu Yu @ 2009-01-21 9:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Liu Yu
Signed-off-by: Liu Yu <yu.liu@freescale.com>
---
vl.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 63d954b..1bf13c0 100644
--- a/vl.c
+++ b/vl.c
@@ -5548,6 +5548,8 @@ int main(int argc, char **argv, char **envp)
sdl_display_init(ds, full_screen, no_frame);
#elif defined(CONFIG_COCOA)
cocoa_display_init(ds, full_screen);
+#else
+ ;
#endif
}
}
--
1.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit
2009-01-21 9:47 [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit Liu Yu
@ 2009-01-21 11:05 ` Stefano Stabellini
2009-01-21 15:59 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2009-01-21 11:05 UTC (permalink / raw)
To: qemu-devel; +Cc: Liu Yu
Liu Yu wrote:
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
> vl.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 63d954b..1bf13c0 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -5548,6 +5548,8 @@ int main(int argc, char **argv, char **envp)
> sdl_display_init(ds, full_screen, no_frame);
> #elif defined(CONFIG_COCOA)
> cocoa_display_init(ds, full_screen);
> +#else
> + ;
> #endif
> }
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit
2009-01-21 9:47 [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit Liu Yu
2009-01-21 11:05 ` Stefano Stabellini
@ 2009-01-21 15:59 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2009-01-21 15:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Liu Yu
Liu Yu wrote:
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
>
What particularly circumstance would this be, --disable-sdl?
> ---
> vl.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 63d954b..1bf13c0 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -5548,6 +5548,8 @@ int main(int argc, char **argv, char **envp)
> sdl_display_init(ds, full_screen, no_frame);
> #elif defined(CONFIG_COCOA)
> cocoa_display_init(ds, full_screen);
> +#else
> + ;
>
I'd rather see something like do {} while (0); with a comment.
Regards,
Anthony Liguori
> #endif
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-21 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-21 9:47 [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit Liu Yu
2009-01-21 11:05 ` Stefano Stabellini
2009-01-21 15:59 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).