From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/5] Introduce rules.mak
Date: Wed, 21 Jan 2009 09:57:35 -0600 [thread overview]
Message-ID: <497745EF.2020708@codemonkey.ws> (raw)
In-Reply-To: <1232365643-6417-4-git-send-email-avi@redhat.com>
Avi Kivity wrote:
> Add a file for common makefile rules.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
>
> (Don't forget to 'svn add')
> ---
> Makefile | 8 ++------
> Makefile.target | 7 +------
> rules.mak | 10 ++++++++++
> 3 files changed, 13 insertions(+), 12 deletions(-)
> create mode 100644 rules.mak
>
> diff --git a/Makefile b/Makefile
> index 92a77ba..66e61fc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,6 +7,8 @@ include config-host.mak
>
> VPATH=$(SRC_PATH):$(SRC_PATH)/hw
>
> +include rules.mak
>
This breaks the build from an external directory. You at least need to
do include $(SRC_PATH)/rules.mak
I noticed you didn't cover the ar command, any particular reason?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-01-21 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 11:47 [Qemu-devel] [PATCH 0/5] Makefile enhancements Avi Kivity
2009-01-19 11:47 ` [Qemu-devel] [PATCH 1/5] Drop OP_CFLAGS Avi Kivity
2009-01-19 11:47 ` [Qemu-devel] [PATCH 2/5] Consolidate compiler invocations Avi Kivity
2009-01-19 11:47 ` [Qemu-devel] [PATCH 3/5] Introduce rules.mak Avi Kivity
2009-01-21 15:57 ` Anthony Liguori [this message]
2009-01-21 17:08 ` [Qemu-devel] " Avi Kivity
2009-01-19 11:47 ` [Qemu-devel] [PATCH 4/5] Consolidate linker rules Avi Kivity
2009-01-19 11:47 ` [Qemu-devel] [PATCH 5/5] Make make output quieter Avi Kivity
2009-01-19 16:03 ` [Qemu-devel] Re: [PATCH 0/5] Makefile enhancements Anthony Liguori
2009-01-19 16:14 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497745EF.2020708@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).