From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPfSl-000864-Vn
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 10:57:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPfSg-0007zA-VZ
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 10:57:55 -0500
Received: from [199.232.76.173] (port=38746 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPfSg-0007yt-Pw
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 10:57:50 -0500
Received: from mail-qy0-f20.google.com ([209.85.221.20]:64278)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LPfSg-0005VC-By
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 10:57:50 -0500
Received: by qyk13 with SMTP id 13so5672159qyk.10
	for <qemu-devel@nongnu.org>; Wed, 21 Jan 2009 07:57:49 -0800 (PST)
Message-ID: <497745EF.2020708@codemonkey.ws>
Date: Wed, 21 Jan 2009 09:57:35 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1232365643-6417-1-git-send-email-avi@redhat.com>
	<1232365643-6417-4-git-send-email-avi@redhat.com>
In-Reply-To: <1232365643-6417-4-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/5] Introduce rules.mak
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

Avi Kivity wrote:
> Add a file for common makefile rules.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
>
> (Don't forget to 'svn add')
> ---
>  Makefile        |    8 ++------
>  Makefile.target |    7 +------
>  rules.mak       |   10 ++++++++++
>  3 files changed, 13 insertions(+), 12 deletions(-)
>  create mode 100644 rules.mak
>
> diff --git a/Makefile b/Makefile
> index 92a77ba..66e61fc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,6 +7,8 @@ include config-host.mak
>  
>  VPATH=$(SRC_PATH):$(SRC_PATH)/hw
>  
> +include rules.mak
>   

This breaks the build from an external directory.  You at least need to 
do include $(SRC_PATH)/rules.mak

I noticed you didn't cover the ar command, any particular reason?

Regards,

Anthony Liguori