From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Liu Yu <yu.liu@freescale.com>
Subject: Re: [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit
Date: Wed, 21 Jan 2009 09:59:34 -0600 [thread overview]
Message-ID: <49774666.9030609@codemonkey.ws> (raw)
In-Reply-To: <1232531266-5295-1-git-send-email-yu.liu@freescale.com>
Liu Yu wrote:
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
>
What particularly circumstance would this be, --disable-sdl?
> ---
> vl.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 63d954b..1bf13c0 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -5548,6 +5548,8 @@ int main(int argc, char **argv, char **envp)
> sdl_display_init(ds, full_screen, no_frame);
> #elif defined(CONFIG_COCOA)
> cocoa_display_init(ds, full_screen);
> +#else
> + ;
>
I'd rather see something like do {} while (0); with a comment.
Regards,
Anthony Liguori
> #endif
> }
> }
>
prev parent reply other threads:[~2009-01-21 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 9:47 [Qemu-devel] [PATCH] Fix a compile error when none of the defines is hit Liu Yu
2009-01-21 11:05 ` Stefano Stabellini
2009-01-21 15:59 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49774666.9030609@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).