From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPfUc-0000M4-Ap
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 10:59:50 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPfUa-0000LL-M0
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 10:59:49 -0500
Received: from [199.232.76.173] (port=38765 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPfUa-0000LD-DR
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 10:59:48 -0500
Received: from mail-qy0-f20.google.com ([209.85.221.20]:40873)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LPfUa-0005eI-1a
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 10:59:48 -0500
Received: by qyk13 with SMTP id 13so5673901qyk.10
	for <qemu-devel@nongnu.org>; Wed, 21 Jan 2009 07:59:47 -0800 (PST)
Message-ID: <49774666.9030609@codemonkey.ws>
Date: Wed, 21 Jan 2009 09:59:34 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix a compile error when none of the defines
	is hit
References: <1232531266-5295-1-git-send-email-yu.liu@freescale.com>
In-Reply-To: <1232531266-5295-1-git-send-email-yu.liu@freescale.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Liu Yu <yu.liu@freescale.com>

Liu Yu wrote:
> Signed-off-by: Liu Yu <yu.liu@freescale.com>
>   

What particularly circumstance would this be, --disable-sdl?

> ---
>  vl.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 63d954b..1bf13c0 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -5548,6 +5548,8 @@ int main(int argc, char **argv, char **envp)
>                      sdl_display_init(ds, full_screen, no_frame);
>  #elif defined(CONFIG_COCOA)
>                      cocoa_display_init(ds, full_screen);
> +#else
> +		    ;
>   

I'd rather see something like do {} while (0); with a comment.

Regards,

Anthony Liguori

>  #endif
>              }
>      }
>