From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPgYm-0004WA-KE for qemu-devel@nongnu.org; Wed, 21 Jan 2009 12:08:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPgYl-0004Vg-Ta for qemu-devel@nongnu.org; Wed, 21 Jan 2009 12:08:12 -0500 Received: from [199.232.76.173] (port=47166 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPgYl-0004Vc-NO for qemu-devel@nongnu.org; Wed, 21 Jan 2009 12:08:11 -0500 Received: from mx2.redhat.com ([66.187.237.31]:50951) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LPgYl-0004ty-8Q for qemu-devel@nongnu.org; Wed, 21 Jan 2009 12:08:11 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0LH8A0W030686 for ; Wed, 21 Jan 2009 12:08:10 -0500 Message-ID: <49775671.6050901@redhat.com> Date: Wed, 21 Jan 2009 19:08:01 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 3/5] Introduce rules.mak References: <1232365643-6417-1-git-send-email-avi@redhat.com> <1232365643-6417-4-git-send-email-avi@redhat.com> <497745EF.2020708@codemonkey.ws> In-Reply-To: <497745EF.2020708@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: >> VPATH=$(SRC_PATH):$(SRC_PATH)/hw >> >> +include rules.mak >> > > This breaks the build from an external directory. You at least need > to do include $(SRC_PATH)/rules.mak Must have thought VPATH would cover it for me. Fixed. > > I noticed you didn't cover the ar command, any particular reason? Laziness. -- error compiling committee.c: too many arguments to function