From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPiIa-0000fr-Hm
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 13:59:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPiIY-0000dj-Py
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 13:59:36 -0500
Received: from [199.232.76.173] (port=46728 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPiIY-0000dP-Bm
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 13:59:34 -0500
Received: from e2.ny.us.ibm.com ([32.97.182.142]:60080)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LPiIX-0000AG-VY
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 13:59:34 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0LIvxpE029714
	for <qemu-devel@nongnu.org>; Wed, 21 Jan 2009 13:57:59 -0500
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n0LIxWJ1155902
	for <qemu-devel@nongnu.org>; Wed, 21 Jan 2009 13:59:32 -0500
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n0LIxWcI013948
	for <qemu-devel@nongnu.org>; Wed, 21 Jan 2009 13:59:32 -0500
Received: from squirrel.codemonkey.ws (sig-9-65-86-47.mts.ibm.com [9.65.86.47])
	by d01av03.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	n0LIxWdG013886
	for <qemu-devel@nongnu.org>; Wed, 21 Jan 2009 13:59:32 -0500
Message-ID: <49777089.8050502@us.ibm.com>
Date: Wed, 21 Jan 2009 12:59:21 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Adds null check for DisplayStatus
References: <E1LNtzL-0002pj-7r@cvs.savannah.gnu.org>	<4973267B.9010901@juno.dti.ne.jp>	<49734152.7080302@juno.dti.ne.jp>	<49746680.3070400@eu.citrix.com>	<49749B91.6080200@juno.dti.ne.jp>	<49749CB7.1020508@eu.citrix.com>	<4974A593.1020607@codemonkey.ws>	<4974A802.7080506@eu.citrix.com>	<4974CF8B.5080409@codemonkey.ws>
	<4975AD3E.8050101@eu.citrix.com>
In-Reply-To: <4975AD3E.8050101@eu.citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefano Stabellini wrote:
> Allocate a DisplaySurface in dumb_display_init if none else does it.
> The DisplaySurface will be used for the qemu monitor, serial and
> parallel ports, etc.
>
> Signed-off-by: Andrew May  <acmay@acmay.homeip.net>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> diff --git a/vl.c b/vl.c
> index 63d954b..b246e47 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2778,6 +2778,11 @@ DisplayState *get_displaystate(void)
>  static void dumb_display_init(void)
>  {
>      DisplayState *ds = qemu_mallocz(sizeof(DisplayState));
> +    if (ds == NULL) {
> +        fprintf(stderr, "dumb_display_init: DisplayState allocation failed\n");
> +        exit(1);
> +    }
> +    ds->surface = qemu_create_displaysurface(640, 480, 32, 640 * 4);
>      register_displaystate(ds);
>  }
>  
>
>
>
>