From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPizk-0003v5-35
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 14:44:12 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPizi-0003tv-E3
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 14:44:11 -0500
Received: from [199.232.76.173] (port=37355 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPizi-0003tq-5d
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 14:44:10 -0500
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:50052
	helo=SMTP.EU.CITRIX.COM)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Stefano.Stabellini@eu.citrix.com>)
	id 1LPizh-0004h0-OY
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 14:44:09 -0500
Message-ID: <49777A05.3090403@eu.citrix.com>
Date: Wed, 21 Jan 2009 19:39:49 +0000
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6391] Fix nographic mode and VNC
References: <E1LPikI-0005cS-RK@cvs.savannah.gnu.org>
In-Reply-To: <E1LPikI-0005cS-RK@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

If you just want to always have a timer enabled maybe this patch is better.
I wouldn't want you to add another timer when the gui_timer is available
for this job :)


diff --git a/vl.c b/vl.c
index 63d954b..2e84dce 100644
--- a/vl.c
+++ b/vl.c
@@ -5553,14 +5553,8 @@ int main(int argc, char **argv, char **envp)
     }
     dpy_resize(ds);
 
-    dcl = ds->listeners;
-    while (dcl != NULL) {
-        if (dcl->dpy_refresh != NULL) {
-            ds->gui_timer = qemu_new_timer(rt_clock, gui_update, ds);
-            qemu_mod_timer(ds->gui_timer, qemu_get_clock(rt_clock));
-        }
-        dcl = dcl->next;
-    }
+    ds->gui_timer = qemu_new_timer(rt_clock, gui_update, ds);
+    qemu_mod_timer(ds->gui_timer, qemu_get_clock(rt_clock));
 
     text_consoles_set_display(display_state);