From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPkyv-0008JX-1K
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 16:51:29 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPkyr-0008G0-4m
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 16:51:28 -0500
Received: from [199.232.76.173] (port=40873 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPkyq-0008Fq-V8
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 16:51:25 -0500
Received: from mail-qy0-f20.google.com ([209.85.221.20]:32811)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LPkyq-0008OM-JY
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 16:51:24 -0500
Received: by qyk13 with SMTP id 13so5954541qyk.10
	for <qemu-devel@nongnu.org>; Wed, 21 Jan 2009 13:51:24 -0800 (PST)
Message-ID: <497798CA.6020801@codemonkey.ws>
Date: Wed, 21 Jan 2009 15:51:06 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option -
	revised
References: <4967A96B.3020902@eu.citrix.com>
	<4969A57D.2020708@redhat.com>	<49776477.4020204@eu.citrix.com>
	<20090121182351.GB3122@redhat.com>
In-Reply-To: <20090121182351.GB3122@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org

Daniel P. Berrange wrote:
> On Wed, Jan 21, 2009 at 01:07:51PM -0500, Trolle Selander wrote:
>   
>> Hi all,
>>
>> This is an updated version of the patch after the suggestions/discussion 
>> on the list. It also includes different handling of how the -vga option 
>> is handled internally, replacing the multiple 
>> independent-yet-mutually-exclusive xxx_vga_enabled variables with one 
>> vgahw_model variable, and also includes the -vga none option added by 
>> Stefano in the time since my last version of this patch. Further 
>> comments & testing welcome. :)
>>     
>
>
>
>   
>> @@ -4933,6 +4930,13 @@
>>              case QEMU_OPTION_vga:
>>                  select_vgahw (optarg);
>>                  break;
>> +            case QEMU_OPTION_videoram:
>> +                {
>> +                    char *ptr;
>> +                    vga_ram_size = strtol(optarg,&ptr,10);
>> +                    vga_ram_size *= 1024 * 1024;
>> +                }
>> +                break;
>>              case QEMU_OPTION_g:
>>                  {
>>                      const char *p;
>>     
>
> Rather than adding more add hoc extra parameters for VGA tunables, we 
> should just make -vga work like the other generic device args, accepting
> a optional list comma separated values following it
>
> eg 
>
>   -vga cirrus,ram=32
>   

Agreed.

Regards,

Anthony Liguori

> Regards,
> Daniel
>