From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [6392] Add BIOS fixes from KVM tree
Date: Thu, 22 Jan 2009 01:14:32 +0100 [thread overview]
Message-ID: <4977BA68.2070206@gmx.net> (raw)
In-Reply-To: <E1LPktw-0002qU-Oq@cvs.savannah.gnu.org>
Hi,
I'm sorry to say that, but my tests showed that
0004_kvm-bios-add-mtrr-support.patch is buggy. It reads MSR_MTRRcap
unconditionally which is not allowed if the CPUID features do not have
CPUID_MTRR set. Real hardware will #GP in that case.
This was found by my MSR access tracing patch.
Please add a check for the CPUID_MTRR feature bit before reading
MSR_MTRRcap. Thanks.
Regards,
Carl-Daniel
On 21.01.2009 22:46, Anthony Liguori wrote:
> Revision: 6392
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6392
> Author: aliguori
> Date: 2009-01-21 21:46:20 +0000 (Wed, 21 Jan 2009)
>
> Log Message:
> -----------
> Add BIOS fixes from KVM tree
>
> See each patch for individual Signed-off-by's/commit logs
>
> [...]
> Added Paths:
> -----------
> trunk/pc-bios/bios-pq/0002_kvm-bios-update-smbios-table-to-report-memory-above-4g.patch
> trunk/pc-bios/bios-pq/0003_kvm-bios-generate-mptable-unconditionally.patch
> trunk/pc-bios/bios-pq/0004_kvm-bios-add-mtrr-support.patch
> trunk/pc-bios/bios-pq/0005_kvm-bios-smp-mtrr-support.patch
> trunk/pc-bios/bios-pq/0006_kvm-bios-extend-mtrrs-to-above-4g.patch
> trunk/pc-bios/bios-pq/0007_kvm-bios-cleanup-consolidate-above-4g-memory-parsing.patch
> trunk/pc-bios/bios-pq/0008_kvm-bios-switch-mtrrs-to-cover-only-the-pci-range-and--default-to-wb.patch
> trunk/pc-bios/bios-pq/0009_kvm-bios-resolve-memory-device-roll-over-reporting--issues-with-32g-guests.patch
> trunk/pc-bios/bios-pq/0010_kvm-bios-fix-smbios-memory-device-length-boundary--condition.patch
>
--
http://www.hailfinger.org/
next prev parent reply other threads:[~2009-01-22 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 21:46 [Qemu-devel] [6392] Add BIOS fixes from KVM tree Anthony Liguori
2009-01-22 0:14 ` Carl-Daniel Hailfinger [this message]
2009-01-22 19:36 ` [Qemu-devel] " Sebastian Herbszt
2009-01-22 20:53 ` [Qemu-devel] " Marcelo Tosatti
2009-01-22 21:15 ` Anthony Liguori
2009-01-22 22:51 ` Sebastian Herbszt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4977BA68.2070206@gmx.net \
--to=c-d.hailfinger.devel.2006@gmx.net \
--cc=avi@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).