From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPnDL-0001pf-IN
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 19:14:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPnDK-0001pH-PD
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 19:14:31 -0500
Received: from [199.232.76.173] (port=37617 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPnDK-0001p9-Mf
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 19:14:30 -0500
Received: from mail.gmx.net ([213.165.64.20]:56318)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <c-d.hailfinger.devel.2006@gmx.net>)
	id 1LPnDK-00039S-7z
	for qemu-devel@nongnu.org; Wed, 21 Jan 2009 19:14:30 -0500
Message-ID: <4977BA68.2070206@gmx.net>
Date: Thu, 22 Jan 2009 01:14:32 +0100
From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6392] Add BIOS fixes from KVM tree
References: <E1LPktw-0002qU-Oq@cvs.savannah.gnu.org>
In-Reply-To: <E1LPktw-0002qU-Oq@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>

Hi,

I'm sorry to say that, but my tests showed that
0004_kvm-bios-add-mtrr-support.patch is buggy. It reads MSR_MTRRcap
unconditionally which is not allowed if the CPUID features do not have
CPUID_MTRR set. Real hardware will #GP in that case.
This was found by my MSR access tracing patch.

Please add a check for the CPUID_MTRR feature bit before reading
MSR_MTRRcap. Thanks.

Regards,
Carl-Daniel

On 21.01.2009 22:46, Anthony Liguori wrote:
> Revision: 6392
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6392
> Author:   aliguori
> Date:     2009-01-21 21:46:20 +0000 (Wed, 21 Jan 2009)
>
> Log Message:
> -----------
> Add BIOS fixes from KVM tree
>
> See each patch for individual Signed-off-by's/commit logs
>
> [...]
> Added Paths:
> -----------
>     trunk/pc-bios/bios-pq/0002_kvm-bios-update-smbios-table-to-report-memory-above-4g.patch
>     trunk/pc-bios/bios-pq/0003_kvm-bios-generate-mptable-unconditionally.patch
>     trunk/pc-bios/bios-pq/0004_kvm-bios-add-mtrr-support.patch
>     trunk/pc-bios/bios-pq/0005_kvm-bios-smp-mtrr-support.patch
>     trunk/pc-bios/bios-pq/0006_kvm-bios-extend-mtrrs-to-above-4g.patch
>     trunk/pc-bios/bios-pq/0007_kvm-bios-cleanup-consolidate-above-4g-memory-parsing.patch
>     trunk/pc-bios/bios-pq/0008_kvm-bios-switch-mtrrs-to-cover-only-the-pci-range-and--default-to-wb.patch
>     trunk/pc-bios/bios-pq/0009_kvm-bios-resolve-memory-device-roll-over-reporting--issues-with-32g-guests.patch
>     trunk/pc-bios/bios-pq/0010_kvm-bios-fix-smbios-memory-device-length-boundary--condition.patch
>   
-- 
http://www.hailfinger.org/