From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LQ3Du-0002qs-VM
	for qemu-devel@nongnu.org; Thu, 22 Jan 2009 12:20:11 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LQ3Dq-0002nz-53
	for qemu-devel@nongnu.org; Thu, 22 Jan 2009 12:20:10 -0500
Received: from [199.232.76.173] (port=40325 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LQ3Dp-0002nq-QW
	for qemu-devel@nongnu.org; Thu, 22 Jan 2009 12:20:05 -0500
Received: from e4.ny.us.ibm.com ([32.97.182.144]:51621)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1LQ3Dp-0006VC-Af
	for qemu-devel@nongnu.org; Thu, 22 Jan 2009 12:20:05 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0MHISck015992
	for <qemu-devel@nongnu.org>; Thu, 22 Jan 2009 12:18:28 -0500
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	n0MHK4b8188290
	for <qemu-devel@nongnu.org>; Thu, 22 Jan 2009 12:20:04 -0500
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n0MHK3jb009565
	for <qemu-devel@nongnu.org>; Thu, 22 Jan 2009 12:20:04 -0500
Message-ID: <4978AAB8.6020604@us.ibm.com>
Date: Thu, 22 Jan 2009 11:19:52 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] install man-pages as non-executables
References: <1232397688131-git-send-email-andre.przywara@amd.com>
In-Reply-To: <1232397688131-git-send-email-andre.przywara@amd.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Andre Przywara <andre.przywara@amd.com>

Andre Przywara wrote:
> make install-doc omits an explicit permission mask for the man-pages. This
> defaults to have the executable bits set. Adding "-m 644" (for rw-r--r--)
> fixes that.
>
> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>  Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 8cbdcda..fc7809d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -233,9 +233,9 @@ install-doc: $(DOCS)
>  	$(INSTALL) -m 644 qemu-doc.html  qemu-tech.html "$(DESTDIR)$(docdir)"
>  ifndef CONFIG_WIN32
>  	mkdir -p "$(DESTDIR)$(mandir)/man1"
> -	$(INSTALL) qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
> +	$(INSTALL) -m 644 qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
>  	mkdir -p "$(DESTDIR)$(mandir)/man8"
> -	$(INSTALL) qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
> +	$(INSTALL) -m 644 qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
>  endif
>  
>  install: all $(if $(BUILD_DOCS),install-doc)
>