From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LQ6tq-0005UU-BI
	for qemu-devel@nongnu.org; Thu, 22 Jan 2009 16:15:42 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LQ6tp-0005Sr-G5
	for qemu-devel@nongnu.org; Thu, 22 Jan 2009 16:15:41 -0500
Received: from [199.232.76.173] (port=49424 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LQ6to-0005SB-Ml
	for qemu-devel@nongnu.org; Thu, 22 Jan 2009 16:15:40 -0500
Received: from qw-out-1920.google.com ([74.125.92.149]:31521)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LQ6to-0008DL-9o
	for qemu-devel@nongnu.org; Thu, 22 Jan 2009 16:15:40 -0500
Received: by qw-out-1920.google.com with SMTP id 5so852196qwc.4
	for <qemu-devel@nongnu.org>; Thu, 22 Jan 2009 13:15:39 -0800 (PST)
Message-ID: <4978E1ED.90309@codemonkey.ws>
Date: Thu, 22 Jan 2009 15:15:25 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6392] Add BIOS fixes from KVM tree
References: <E1LPktw-0002qU-Oq@cvs.savannah.gnu.org>
	<4977BA68.2070206@gmx.net> <20090122205314.GA5478@amt.cnet>
In-Reply-To: <20090122205314.GA5478@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Sebastian Herbszt <herbszt@gmx.de>, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>, Avi Kivity <avi@redhat.com>

Marcelo Tosatti wrote:
> On Thu, Jan 22, 2009 at 01:14:32AM +0100, Carl-Daniel Hailfinger wrote:
>   
>> Hi,
>>
>> I'm sorry to say that, but my tests showed that
>> 0004_kvm-bios-add-mtrr-support.patch is buggy. It reads MSR_MTRRcap
>> unconditionally which is not allowed if the CPUID features do not have
>> CPUID_MTRR set. Real hardware will #GP in that case.
>> This was found by my MSR access tracing patch.
>>
>> Please add a check for the CPUID_MTRR feature bit before reading
>> MSR_MTRRcap. Thanks.
>>     
>
> Attached, can you confirm it works for you, please?
>   

Please work with Sebastian on this.  I'll just pull this fix in from 
upstream Bochs once it's all integrated.

Regards,

Anthony Liguori