From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQJ7d-0003JO-PE for qemu-devel@nongnu.org; Fri, 23 Jan 2009 05:18:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQJ7c-0003IK-Q2 for qemu-devel@nongnu.org; Fri, 23 Jan 2009 05:18:45 -0500 Received: from [199.232.76.173] (port=42202 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQJ7c-0003I7-IH for qemu-devel@nongnu.org; Fri, 23 Jan 2009 05:18:44 -0500 Received: from cantor.suse.de ([195.135.220.2]:60137 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LQJ7c-0000VF-8U for qemu-devel@nongnu.org; Fri, 23 Jan 2009 05:18:44 -0500 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 021DB44968 for ; Fri, 23 Jan 2009 11:18:41 +0100 (CET) Message-ID: <49799AF2.8090303@suse.de> Date: Fri, 23 Jan 2009 11:24:50 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 8/9] New option -audio as a more flexible alternative to -soundhw References: <87ocxzrvqb.fsf@pike.pond.sub.org> <1232652665-1710-8-git-send-email-armbru@redhat.com> <87ljt2qv60.fsf@pike.pond.sub.org> <49798DE6.5090208@suse.de> <87hc3qpcd9.fsf@pike.pond.sub.org> In-Reply-To: <87hc3qpcd9.fsf@pike.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Markus Armbruster schrieb: > Kevin Wolf writes: > >> Markus Armbruster schrieb: >>> malc writes: >>> >>>> On Thu, 22 Jan 2009, Markus Armbruster wrote: >>>> >>>>> From: Markus Armbruster >>>>> >>>>> This is in preparation of pci=... support for audio devices. -soundhw >>>>> doesn't support the common name=value,... syntax. >>>>> --- >>>>> sysemu.h | 1 + >>>>> vl.c | 94 ++++++++++++++++++++++++++++++++++++++++++++----------------- >>>>> 2 files changed, 69 insertions(+), 26 deletions(-) >>>> This as, i guess, the rest of the patches is tab damaged. The >>>> documentation wasn't updated either. >>>> >>>> [..snip..] >>> It's just a sketch. How would you like your tabs? >> Probably four spaces, just like in the surrounding code (as almost >> everywhere in qemu). >> >> Kevin > > Can't see where I got that wrong. > > Any preference on use of the tab character? Most of the qemu code only uses spaces, no real tabs. Kevin